On Tue, 2019-07-23 at 17:02 +0100, Daniel P. Berrangé wrote: [...] > +++ b/src/secret/virtsecretd.service.in [...] > +[Install] > +WantedBy=multi-user.target > +Also=virtsecretd.socket > +Also=virtsecretd-ro.socket > +Also=virtsecretd-admin.socket Interestingly, we *do* include the admin socket here, and for all other newly-introduced daemons too it would seem! Anyway, with the caveat that the comments made for previous patches are addressed here as well if they apply, Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx> -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list