On Fri, Jul 26, 2019 at 05:19:56PM +0200, Andrea Bolognani wrote: > On Tue, 2019-07-23 at 17:02 +0100, Daniel P. Berrangé wrote: > > The same make variables will be useful for building both libvirtd and > > the split daemons, so refactor & rename variables to facilitate reuse. > > > > Automake gets annoyed if you define a variable ending LDFLAGS: > > > > src/remote/Makefile.inc.am:53: warning: variable 'REMOTE_DAEMON_LDFLAGS' is defined but no program or > > src/remote/Makefile.inc.am:53: library has 'REMOTE_DAEMON' as canonical name (possible typo) > > I'd indent this by two spaces for readabilty. > > You're recreating the pre-existing setup faithfully, so > > Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx> > > [...] > > +REMOTE_DAEMON_LD_ADD += \ > > + ../gnulib/lib/libgnu.la \ > > + $(LIBSOCKET) \ > > + $(NULL) > > As an aside, it looks like $(LIBSOCKET) is a leftover of days long > gone and no longer used for anything. It is something that gnulib defines. Whether it expands to a non-empty string on any of our supported build platforms though, I don't know. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
