On Tue, Jul 23, 2019 at 02:08:49PM +0200, Peter Krempa wrote:
In case when the backing store can be represented with something simpler such as an URI we can use it rather than falling back to the
a URI
json: pseudo-protocol. In cases when it's not worth it (e.g. with the old ugly NBD or RBD strings let's switch to json).
the parenthesis should end earlier
The function is exported as we'll need it when overwriting the ugly strings qemu would come up with during blockjobs. Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx> --- src/qemu/qemu_block.c | 93 ++++++++++++++----- src/qemu/qemu_block.h | 4 + .../imagecreate/qcow2-backing-raw-nbd.json | 2 +- 3 files changed, 76 insertions(+), 23 deletions(-)
This would have been easier to read if you had split the functional change from code movement. Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx> Jano
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
