Re: [PATCH v10 12/19] backup: Implement virsh support for checkpoints

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 24, 2019 at 12:56:02AM -0500, Eric Blake wrote:
> Introduce a bunch of new virsh commands for managing checkpoints in
> isolation. More commands are needed for performing incremental
> backups, but these commands were easy to implement by modeling heavily
> after virsh-snapshot.c. There is no need for checkpoint-revert or
> checkpoint-current since those snapshot APIs have no checkpoint
> counterpart.  Similarly, it is not necessary to change which
> checkpoint is current when redefining from XML, since checkpoints
> expose whether they are current in the public XML (rather than the way
> snapshots did it behind the scenese).  checkpoint-list is a bit
> simpler, in part because we don't have to cater to back-compat to
> older API.  checkpoint-info is a bit trickier, because it requires
> parsing XML (maybe we'll want virDomainCheckpointIsCurrent() as an API
> after all).

Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>


> diff --git a/tools/virsh-checkpoint.c b/tools/virsh-checkpoint.c
> new file mode 100644
> index 0000000000..f6401f2cf0
> --- /dev/null
> +++ b/tools/virsh-checkpoint.c
> @@ -0,0 +1,1153 @@
> +/*
> + * virsh-checkpoint.c: Commands to manage domain checkpoints
> + *
> + * Copyright (C) 2005-2019 Red Hat, Inc.
> + *
> + * This library is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Lesser General Public
> + * License as published by the Free Software Foundation; either
> + * version 2.1 of the License, or (at your option) any later version.
> + *
> + * This library is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * Lesser General Public License for more details.
> + *
> + * You should have received a copy of the GNU Lesser General Public
> + * License along with this library.  If not, see
> + * <http://www.gnu.org/licenses/>.
> + *
> + *  Daniel Veillard <veillard@xxxxxxxxxx>
> + *  Karel Zak <kzak@xxxxxxxxxx>
> + *  Daniel P. Berrange <berrange@xxxxxxxxxx>

We purged all authors from the source, only copyright & license
lines need to be preserved when copying files.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux