Re: [PATCH v10 05/19] backup: Document new XML for checkpoints

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 24, 2019 at 12:55:55AM -0500, Eric Blake wrote:
> Prepare for new checkpoint APIs by describing the XML that will
> represent a checkpoint.  The checkpoint XML is modeled heavily after
> virDomainSnapshotPtr. See the docs for more details.
> 
> Add testsuite coverage for some minimal uses of the XML (bare minimum,
> the sample from html, and a full dumpxml, and some counter-examples
> that should fail schema validation). Although use of the REDEFINE flag
> will require the <domain> subelement to be present, it is easier for
> most of the tests to provide counterpart output produced with the
> NO_DOMAIN flag (particularly since synthesizing a valid <domain>
> during testing is not trivial).
> 
> Signed-off-by: Eric Blake <eblake@xxxxxxxxxx>
> ---
>  docs/docs.html.in                             |   3 +-
>  docs/format.html.in                           |   1 +
>  docs/formatcheckpoint.html.in                 | 194 ++++++++++++++++++
>  docs/index.html.in                            |   3 +-
>  docs/schemas/domaincheckpoint.rng             |  94 +++++++++
>  libvirt.spec.in                               |   1 +
>  mingw-libvirt.spec.in                         |   2 +
>  tests/Makefile.am                             |   2 +
>  .../disk-default.xml                          |   7 +
>  .../disk-invalid.xml                          |   8 +
>  tests/qemudomaincheckpointxml2xmlin/empty.xml |   1 +
>  .../name-invalid.xml                          |   4 +
>  .../qemudomaincheckpointxml2xmlin/sample.xml  |   7 +
>  tests/qemudomaincheckpointxml2xmlin/size.xml  |   4 +
>  .../disk-default.xml                          |  11 +
>  .../qemudomaincheckpointxml2xmlout/empty.xml  |   7 +
>  .../redefine.xml                              |  63 ++++++
>  .../qemudomaincheckpointxml2xmlout/sample.xml |  12 ++
>  tests/qemudomaincheckpointxml2xmlout/size.xml |  11 +
>  tests/virschematest.c                         |   2 +
>  20 files changed, 435 insertions(+), 2 deletions(-)
>  create mode 100644 docs/formatcheckpoint.html.in
>  create mode 100644 docs/schemas/domaincheckpoint.rng
>  create mode 100644 tests/qemudomaincheckpointxml2xmlin/disk-default.xml
>  create mode 100644 tests/qemudomaincheckpointxml2xmlin/disk-invalid.xml
>  create mode 100644 tests/qemudomaincheckpointxml2xmlin/empty.xml
>  create mode 100644 tests/qemudomaincheckpointxml2xmlin/name-invalid.xml
>  create mode 100644 tests/qemudomaincheckpointxml2xmlin/sample.xml
>  create mode 100644 tests/qemudomaincheckpointxml2xmlin/size.xml
>  create mode 100644 tests/qemudomaincheckpointxml2xmlout/disk-default.xml
>  create mode 100644 tests/qemudomaincheckpointxml2xmlout/empty.xml
>  create mode 100644 tests/qemudomaincheckpointxml2xmlout/redefine.xml
>  create mode 100644 tests/qemudomaincheckpointxml2xmlout/sample.xml
>  create mode 100644 tests/qemudomaincheckpointxml2xmlout/size.xml

Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux