On Mon, 2019-07-22 at 15:47 +0100, Daniel P. Berrangé wrote: > The various distros have the following libxml2 vesions: s/vesions/versions/ [...] > AC_DEFUN([LIBVIRT_ARG_LIBXML], [ > - LIBVIRT_ARG_WITH([LIBXML], [libxml-2.0 (>= 2.6.0) location], [check]) > + LIBVIRT_ARG_WITH([LIBXML], [libxml-2.0 (>= 2.9.1) location], [check]) Why are we even recording the minimum version number here? The only effect is that at some point someone will forget to update both at the same time, and users will get confused. Please just drop it altogether. Other than the nits above, lovely cleanup! Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx> -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
