Re: [PATCH] util: Fix broken MinGW builds caused by commit 9bc01ad8

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 19, 2019 at 08:39:35 +0200, Peter Krempa wrote:
> On Fri, Jul 19, 2019 at 08:30:34 +0200, Erik Skultety wrote:
> > virPCIGetSysfsFile is conditionally compiled only on Linux platforms.
> > 
> > Signed-off-by: Erik Skultety <eskultet@xxxxxxxxxx>
> > ---
> > 
> > Pushed under the build breaker rule.
> > 
> >  src/util/virpci.c | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> > 
> > diff --git a/src/util/virpci.c b/src/util/virpci.c
> > index 75e8daadd5..ae3a0fa886 100644
> > --- a/src/util/virpci.c
> > +++ b/src/util/virpci.c
> > @@ -3099,6 +3099,14 @@ virPCIGetVirtualFunctionIndex(const char *pf_sysfs_device_link ATTRIBUTE_UNUSED,
> > 
> >  }
> > 
> > +int
> > +virPCIGetSysfsFile(char *virPCIDeviceName ATTRIBUTE_UNUSED,
> > +                   char **pci_sysfs_device_link ATTRIBUTE_UNUSED)
> > +{
> > +    virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _(unsupported));
> 
> I think you forgot quotes around the "unsupported" string.

Never mind. I looked at the code and 'unsupported' is a global static
string in that module. I didn't expect that

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux