Re: [dockerfiles PATCH 0/3] Add libosinfo-related projects

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Andrea,

On Thu, 2019-07-18 at 14:20 +0200, Andrea Bolognani wrote:
> See patch 2/3 for more information.
> 
> Andrea Bolognani (3):
>   refresh: Store projects in a more convenient format
>   refresh: Add libosinfo-related projects
>   Refresh after adding libosinfo-related projects
> 
>  buildenv-centos-7.Dockerfile                  | 11 +++++++++
>  buildenv-debian-10-cross-aarch64.Dockerfile   | 15 ++++++++++++
>  buildenv-debian-10-cross-armv6l.Dockerfile    | 15 ++++++++++++
>  buildenv-debian-10-cross-armv7l.Dockerfile    | 15 ++++++++++++
>  buildenv-debian-10-cross-i686.Dockerfile      | 15 ++++++++++++
>  buildenv-debian-10-cross-mips.Dockerfile      | 15 ++++++++++++
>  buildenv-debian-10-cross-mips64el.Dockerfile  | 15 ++++++++++++
>  buildenv-debian-10-cross-mipsel.Dockerfile    | 15 ++++++++++++
>  buildenv-debian-10-cross-ppc64le.Dockerfile   | 15 ++++++++++++
>  buildenv-debian-10-cross-s390x.Dockerfile     | 15 ++++++++++++
>  buildenv-debian-10.Dockerfile                 | 15 ++++++++++++
>  buildenv-debian-9-cross-aarch64.Dockerfile    | 15 ++++++++++++
>  buildenv-debian-9-cross-armv6l.Dockerfile     | 15 ++++++++++++
>  buildenv-debian-9-cross-armv7l.Dockerfile     | 15 ++++++++++++
>  buildenv-debian-9-cross-mips.Dockerfile       | 15 ++++++++++++
>  buildenv-debian-9-cross-mips64el.Dockerfile   | 15 ++++++++++++
>  buildenv-debian-9-cross-mipsel.Dockerfile     | 15 ++++++++++++
>  buildenv-debian-9-cross-ppc64le.Dockerfile    | 15 ++++++++++++
>  buildenv-debian-9-cross-s390x.Dockerfile      | 15 ++++++++++++
>  buildenv-debian-9.Dockerfile                  | 15 ++++++++++++
>  buildenv-debian-sid-cross-aarch64.Dockerfile  | 15 ++++++++++++
>  buildenv-debian-sid-cross-armv6l.Dockerfile   | 15 ++++++++++++
>  buildenv-debian-sid-cross-armv7l.Dockerfile   | 15 ++++++++++++
>  buildenv-debian-sid-cross-i686.Dockerfile     | 15 ++++++++++++
>  buildenv-debian-sid-cross-mips.Dockerfile     | 15 ++++++++++++
>  buildenv-debian-sid-cross-mips64el.Dockerfile | 15 ++++++++++++
>  buildenv-debian-sid-cross-mipsel.Dockerfile   | 15 ++++++++++++
>  buildenv-debian-sid-cross-ppc64le.Dockerfile  | 15 ++++++++++++
>  buildenv-debian-sid-cross-s390x.Dockerfile    | 15 ++++++++++++
>  buildenv-debian-sid.Dockerfile                | 15 ++++++++++++
>  buildenv-fedora-29.Dockerfile                 | 15 ++++++++++++
>  buildenv-fedora-30.Dockerfile                 | 15 ++++++++++++
>  buildenv-fedora-rawhide.Dockerfile            | 24
> +++++++++++++++++++
>  buildenv-ubuntu-16.Dockerfile                 | 15 ++++++++++++
>  buildenv-ubuntu-18.Dockerfile                 | 15 ++++++++++++
>  refresh                                       | 17 +++++++++----
>  36 files changed, 543 insertions(+), 4 deletions(-)
> 


The patches look sane to me. There's one minor comment in the second
patch in the series, tho.

Reviewed-by: Fabiano Fidêncio <fidencio@xxxxxxxxxx>

I'd still wait for Daniel's input before pushing the changes. :-)

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux