Hi, Daniel P. Berrange wrote: > On Tue, Nov 17, 2009 at 12:53:31AM +0100, wolfgang.mauerer@xxxxxxxxxxx wrote: >> Hi, >> >> this is the second revision of a patch series to improve disk >> hotadd support for libvirt. It focuses on the qemu backend, but >> is naturally designed to be compatible with other backends as >> well. The objective is two-fold: >> >> 1.) Split off controller from disk handling. This is done by >> introducing a new domain element <controller> that is used to >> describe disk controllers. Support for hotplugging such >> controllers is added. Support to reference controllers by >> name is also included. >> 2.) <disk>s can now be associated with a specific controller; >> this is done by means of a <controller> subelemnt for disks. >> >> This patch addresses the questions that were raised during the >> review of the initial submission, massages the code by fixing >> some whitespace issues, gets static controller configurations to >> work, and adds documentation. Notice that in contrast to the >> first submission I did not include the patch that adds support >> for disk- and controller hot_remove_. Since the qemu codebase is >> still in bit of a flux wrt. the necessary patches required for >> this functionality, it will reappear some time later as a >> separate submission. > > What libvirt version / GIT changeset did you create these patches > against ? The current libvirt QEMU driver code in GIT is quite > different, so the patches here don't apply for me as is. sorry for the late reply, I could not access my eMail during the last couple of days. Patches are on top of 790f0b3057787bb64, I did not realise that this one was only in the middle of qemu refactoring, not at the end :-( Do you plan any more refactorings to the qemu base in the near future, and if yes, are these already available somewhere? I'd like to avoid another useless rebase... Thanks, Wolfgang -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list