Re: [PATCH 24/29] remote: open secondary drivers via remote driver if needed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 12, 2019 at 03:58:12PM +0200, Ján Tomko wrote:
> On Thu, Jul 11, 2019 at 05:05:11PM +0100, Daniel P. Berrangé wrote:
> > When the client has a connection to one of the hypervisor specific
> > daemons (eg virtqemud), the app may still expect to use the secondary
> > driver APIs (storage, network, etc). None of these will be registered in
> > the hypervisor daemon, so we must explicitly open a connection to each
> > of the daemons for the secondary drivers we need.
> > 
> > Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
> > ---
> > src/remote/remote_daemon_dispatch.c | 82 ++++++++++++++++++++++++-----
> > 1 file changed, 69 insertions(+), 13 deletions(-)
> > 
> > diff --git a/src/remote/remote_daemon_dispatch.c b/src/remote/remote_daemon_dispatch.c
> > index 856c5e48e7..c8a605c709 100644
> > --- a/src/remote/remote_daemon_dispatch.c
> > +++ b/src/remote/remote_daemon_dispatch.c
> 
> [...]
> 
> > +        VIR_DEBUG("Secret driver found");
> > +        priv->secretConn = virObjectRef(priv->conn);
> > +    } else if (STREQ(type, "storage")) {
> > +        VIR_DEBUG("Storage driver found");
> > +        priv->storageConn = virObjectRef(priv->conn);
> > +
> > +        /* Co-open the secret driver, as apps using the storage driver may well
> > +         * need access to secrets for storage auth
> > +         */
> > +        OPEN_DRIVER(secretConn, getuid == 0 ? "secret:///system" : "secret:///session");
> 
> getuid()

Yep, fixed locally shortly after posting this.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux