Re: [PATCH v4 16/23] utils: Mark inpipe as non-blocking

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/12/19 4:24 AM, Daniel P. Berrangé wrote:
On Thu, Jul 11, 2019 at 03:41:44PM -0400, Stefan Berger wrote:
Mark a virCommand's inpipe (write-end of pipe) as non-blocking so that it
will never block when we were to try to write too many bytes to it while
it doesn't have the capacity to hold them.
So this is the right way todo it.  Why did you have the previous patch 15
at all given you've used O_NONBLOCK here ?


I thought that with a buffer bigger than the capacity of a pipe we wouldn't be able to make write progress but that's not the case but it fills up the pipe with whatever fits. I'll drop the MIN() stuff.


--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux