Re: [PATCH v2 1/9] vbox: Add various vir*Flags API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 09, 2019 at 12:46:30 -0500, Eric Blake wrote:
> Even though we don't accept any flags, it is unfriendly to callers
> that use the modern API to have to fall back to the flag-free API.
> 
> Signed-off-by: Eric Blake <eblake@xxxxxxxxxx>
> ---
>  src/vbox/vbox_common.c | 24 ++++++++++++++++++++++--
>  1 file changed, 22 insertions(+), 2 deletions(-)

[...]

> @@ -2775,6 +2788,11 @@ static int vboxDomainSetMemory(virDomainPtr dom, unsigned long memory)
>      return ret;
>  }
> 
> +static int vboxDomainSetMemory(virDomainPtr dom, unsigned long memory)
> +{
> +    return vboxDomainSetMemoryFlags(dom, memory, 0);

The old API was operating on a live VM only so this shim should imply
VIR_DOMAIN_AFFECT_LIVE.

> +}
> +
>  static int vboxDomainGetInfo(virDomainPtr dom, virDomainInfoPtr info)
>  {
>      vboxDriverPtr data = dom->conn->privateData;

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux