[PATCH v2 2/9] xenapi: Add various vir*Flags API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Even though we don't accept any flags, it is unfriendly to callers
that use the modern API to have to fall back to the flag-free API.

Signed-off-by: Eric Blake <eblake@xxxxxxxxxx>
---
 src/xenapi/xenapi_driver.c | 22 +++++++++++++++++++---
 1 file changed, 19 insertions(+), 3 deletions(-)

diff --git a/src/xenapi/xenapi_driver.c b/src/xenapi/xenapi_driver.c
index 672117822f..026acef680 100644
--- a/src/xenapi/xenapi_driver.c
+++ b/src/xenapi/xenapi_driver.c
@@ -1184,19 +1184,21 @@ xenapiDomainSetVcpus(virDomainPtr dom, unsigned int nvcpus)
 }

 /*
- * xenapiDomainPinVcpu
+ * xenapiDomainPinVcpuFlags
  *
  * Dynamically change the real CPUs which can be allocated to a virtual CPU
  * Returns 0 on success or -1 in case of error
  */
 static int
-xenapiDomainPinVcpu(virDomainPtr dom, unsigned int vcpu ATTRIBUTE_UNUSED,
-                    unsigned char *cpumap, int maplen)
+xenapiDomainPinVcpuFlags(virDomainPtr dom, unsigned int vcpu ATTRIBUTE_UNUSED,
+                         unsigned char *cpumap, int maplen,
+                         unsigned int flags)
 {
     char *value = NULL;
     xen_vm vm;
     xen_vm_set *vms;
     xen_session *session = ((struct _xenapiPrivate *)(dom->conn->privateData))->session;
+    virCheckFlags(0, -1);
     if (xen_vm_get_by_name_label(session, &vms, dom->name) && vms->size > 0) {
         if (vms->size != 1) {
             xenapiSessionErrorHandler(dom->conn, VIR_ERR_INTERNAL_ERROR,
@@ -1225,6 +1227,19 @@ xenapiDomainPinVcpu(virDomainPtr dom, unsigned int vcpu ATTRIBUTE_UNUSED,
     return -1;
 }

+/*
+ * xenapiDomainPinVcpu
+ *
+ * Dynamically change the real CPUs which can be allocated to a virtual CPU
+ * Returns 0 on success or -1 in case of error
+ */
+static int
+xenapiDomainPinVcpu(virDomainPtr dom, unsigned int vcpu,
+                    unsigned char *cpumap, int maplen)
+{
+    return xenapiDomainPinVcpuFlags(dom, vcpu, cpumap, maplen, 0);
+}
+
 /*
  * xenapiDomainGetVcpus
  *
@@ -2029,6 +2044,7 @@ static virHypervisorDriver xenapiHypervisorDriver = {
     .domainSetVcpusFlags = xenapiDomainSetVcpusFlags, /* 0.8.5 */
     .domainGetVcpusFlags = xenapiDomainGetVcpusFlags, /* 0.8.5 */
     .domainPinVcpu = xenapiDomainPinVcpu, /* 0.8.0 */
+    .domainPinVcpuFlags = xenapiDomainPinVcpuFlags, /* 5.6.0 */
     .domainGetVcpus = xenapiDomainGetVcpus, /* 0.8.0 */
     .domainGetMaxVcpus = xenapiDomainGetMaxVcpus, /* 0.8.0 */
     .domainGetXMLDesc = xenapiDomainGetXMLDesc, /* 0.8.0 */
-- 
2.20.1

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux