Re: [PATCH 5/8] snapshot: Factor out redefine cycle validation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 05, 2019 at 23:37:32 -0500, Eric Blake wrote:
> The code to check whether a redefined snapshot/checkpoint XML is
> attempting to create a cycle in the list of moments is lengthy, and
> common between the two types of list. Therefore, it belongs in the
> shared base file.
> 
> Signed-off-by: Eric Blake <eblake@xxxxxxxxxx>
> ---
>  src/conf/virdomainmomentobjlist.h   |  3 +++
>  src/conf/virdomainsnapshotobjlist.h |  3 +++
>  src/conf/snapshot_conf.c            | 41 ++++-------------------------
>  src/conf/virdomainmomentobjlist.c   | 40 ++++++++++++++++++++++++++++
>  src/conf/virdomainsnapshotobjlist.c |  9 +++++++
>  tests/virsh-snapshot                |  2 +-
>  6 files changed, 61 insertions(+), 37 deletions(-)

ACK, although it would be great if the new function would also document
what it's doing.

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux