On Thu, Jul 04, 2019 at 01:28:36PM +0200, Ilias Stamatis wrote: > On Thu, Jul 4, 2019 at 12:58 PM Pavel Hrdina <phrdina@xxxxxxxxxx> wrote: > > > > On Wed, Jun 26, 2019 at 06:36:28PM +0200, Ilias Stamatis wrote: > > > Hello, > > > > > > I was thinking about how to implement the following APIs in the test driver: > > > -virDomainFSFreeze > > > -virDomainFSThaw > > > -virDomainFSTrim > > > > > > The first two are conceptually paired. They both get a mountpoints > > > argument. The QEMU driver (which is the only driver implementing this > > > currently) ignores this completely. > > > > What do you mean by "ignores this completely"? From the code the > > mountpoints are passed to QEMU agent and that agent issues appropriate > > commands in the VM OS. > > I meant qemuDomainFSThaw and qemuDomainFSTrime. In the case of > virDomainFSFreeze you are right. Right, I check only FSFreeze, we don't have to copy QEMU driver behavior so if the test driver can easily support it I would go for it. Pavel
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
