Re: [PATCH] remote: remove the only use of LIBVIRTD_CONFIGURATION_FILE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 4, 2019 at 9:28 AM Peter Krempa <pkrempa@xxxxxxxxxx> wrote:
>
> On Thu, Jul 04, 2019 at 08:16:21 +0200, Fabiano Fidêncio wrote:
> > 86fbce56f27e removed the constant, but didn't actually adjust the only
> > place where the constant was used.
> >
> > Signed-off-by: Fabiano Fidêncio <fidencio@xxxxxxxxxx>
> > ---
> > This patch fixes a build breakage.
> >
> > It's either this, or reverting 86fbce56f27e.
>
> I've reverted it now sice the premise that the constant was unused is
> wrong. A separate patch can e.g. squash this change and the removal of
> the constant with a better justification perhaps. Obviously that will
> need to go through review again to consider the merit of the
> justification.

Fair enough! Thanks for taking care of this!

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux