Re: [PATCH] remote: remove the only use of LIBVIRTD_CONFIGURATION_FILE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Fabiano Fidêncio <fidencio@xxxxxxxxxx> [2019-07-04, 08:16AM +0200]:
> 86fbce56f27e removed the constant, but didn't actually adjust the only
> place where the constant was used.
> 
> Signed-off-by: Fabiano Fidêncio <fidencio@xxxxxxxxxx>
> ---
> This patch fixes a build breakage.
> 
> It's either this, or reverting 86fbce56f27e.
> ---
>  src/remote/remote_daemon.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/src/remote/remote_daemon.c b/src/remote/remote_daemon.c
> index fdc9e4333a..3cd7b16163 100644
> --- a/src/remote/remote_daemon.c
> +++ b/src/remote/remote_daemon.c
> @@ -899,9 +899,6 @@ daemonUsage(const char *argv0, bool privileged)
>                  _("\n"
>                    "  Default paths:\n"
>                    "\n"
> -                  "    Configuration file (unless overridden by -f):\n"
> -                  "      %s\n"
> -                  "\n"
>                    "    Sockets:\n"
>                    "      %s\n"
>                    "      %s\n"
> @@ -914,7 +911,6 @@ daemonUsage(const char *argv0, bool privileged)
>                    "    PID file (unless overridden by -p):\n"
>                    "      %s/run/libvirtd.pid\n"
>                    "\n"),
> -                LIBVIRTD_CONFIGURATION_FILE,
>                  LIBVIRTD_PRIV_UNIX_SOCKET,
>                  LIBVIRTD_PRIV_UNIX_SOCKET_RO,
>                  LIBVIRT_CACERT,

So now with this and the original patch we just removed a piece of
useful information? Doesn't make sense to me.

-- 
IBM Systems
Linux on Z & Virtualization Development
--------------------------------------------------
IBM Deutschland Research & Development GmbH
Schönaicher Str. 220, 71032 Böblingen
Phone: +49 7031 16 1819
--------------------------------------------------
Vorsitzende des Aufsichtsrats: Matthias Hartmann
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux