On Wed, Jul 03, 2019 at 12:32:38PM -0400, Cole Robinson wrote:
> Signed-off-by: Cole Robinson <crobinso@xxxxxxxxxx>
> ---
>
> Pushed as a build breaker. Anyone know why we list these
> explicitly rather than use a wildcard? libvirt.spec.in is
> the same
We list pretty much everything explicitly because wildcards
lead to stuff silently going missing if some part of the build
mistakenly goes wrong.
THis does point out though that our CI is missing a job to
test the mingw RPM build - we only test native RPM build
>
> mingw-libvirt.spec.in | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/mingw-libvirt.spec.in b/mingw-libvirt.spec.in
> index 280db4d1aa..ad6d6e952e 100644
> --- a/mingw-libvirt.spec.in
> +++ b/mingw-libvirt.spec.in
> @@ -237,6 +237,7 @@ rm -rf $RPM_BUILD_ROOT%{mingw64_libexecdir}/libvirt-guests.sh
> %{mingw32_datadir}/libvirt/schemas/interface.rng
> %{mingw32_datadir}/libvirt/schemas/network.rng
> %{mingw32_datadir}/libvirt/schemas/networkcommon.rng
> +%{mingw32_datadir}/libvirt/schemas/networkport.rng
> %{mingw32_datadir}/libvirt/schemas/nodedev.rng
> %{mingw32_datadir}/libvirt/schemas/nwfilter.rng
> %{mingw32_datadir}/libvirt/schemas/nwfilter_params.rng
> @@ -325,6 +326,7 @@ rm -rf $RPM_BUILD_ROOT%{mingw64_libexecdir}/libvirt-guests.sh
> %{mingw64_datadir}/libvirt/schemas/interface.rng
> %{mingw64_datadir}/libvirt/schemas/network.rng
> %{mingw64_datadir}/libvirt/schemas/networkcommon.rng
> +%{mingw64_datadir}/libvirt/schemas/networkport.rng
> %{mingw64_datadir}/libvirt/schemas/nodedev.rng
> %{mingw64_datadir}/libvirt/schemas/nwfilter.rng
> %{mingw64_datadir}/libvirt/schemas/nwfilter_params.rng
> --
> 2.21.0
>
> --
> libvir-list mailing list
> libvir-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/libvir-list
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list
