Re: [PATCH 1/2] test_driver: Don't access @vm after it was set to NULL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2019-05-14 at 17:12 +0200, Michal Privoznik wrote:
> If something goes wrong in testDomainGetDiskErrors() then we try
> to free any strings that were previously allocated in return
> array. Problem is, in my review of original patch (89320788ac4)
> I've mistakenly did some changes which result in possible NULL
> dereference (@vm is set to NULL as the first thing under cleanup
> label).
> 
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
>  src/test/test_driver.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux