Re: [PATCH v2 4/4] Revert "error: Add VIR_ERR_DEPRECATED error code"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 27, 2019 at 10:06:05 +0100, Daniel Berrange wrote:
> This reverts commit 226094fbc483128c8888f4171c353aed738b8346.
> 
> A deprecation is a warning to something that use of a feature is
> being discouraged. By definition it is not an error condition to
> continue to use a deprecated feature.
> 
> A VIR_ERR_DEPRECATED constant thus makes no conceptual sense. For
> features which are entirely absent we already document that the
> VIR_ERR_NO_SUPPORT code will be used. There is no need to distinguish
> between a feature which never existed and a feature which previously
> existed and was since removed.
> 
> Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx>
> Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
> ---

ACK

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux