Re: [PATCH 1/4] qemu: delete methods which are no longer supported

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 26, 2019 at 16:54:40 +0100, Daniel Berrange wrote:
> The public API entry points will report VIR_ERR_NO_SUPPORT to the
> caller when a driver does not provide an implementation of a particular
> method.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
> ---
>  src/qemu/qemu_driver.c | 31 -------------------------------
>  1 file changed, 31 deletions(-)

[...]

> @@ -22271,7 +22242,6 @@ static virHypervisorDriver qemuHypervisorDriver = {
>      .domainGetSecurityLabelList = qemuDomainGetSecurityLabelList, /* 0.10.0 */
>      .nodeGetSecurityModel = qemuNodeGetSecurityModel, /* 0.6.1 */
>      .domainGetXMLDesc = qemuDomainGetXMLDesc, /* 0.2.0 */
> -    .connectDomainXMLFromNative = qemuConnectDomainXMLFromNative, /* 0.6.4 (deprecated: 5.5.0) */

This makes documentation strictly worse, where users may be lead into
thinking that this never existed.

I don't think we should just delete it without acknowledging we've
deleted it.

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux