Re: [PATCH 0/4] Remove VIR_ERR_DEPRECATED & associated pieces

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 26, 2019 at 04:54:39PM +0100, Daniel P. Berrangé wrote:
A deprecation is inherantly a warning, not an error, so adding an error
with this name makes no conceptual sense.

Features in drivers may come & go at any time and we've always use the
VIR_ERR_NO_SUPPORT to indicate when a hypervisor driver does not support
a particular API.

Daniel P. Berrangé (4):
 qemu: delete methods which are no longer supported
 Revert "error: Add VIR_ERR_DEPRECATED error code"
 Revert "docs: css: Add style for <span class='deprecated'> ..."
 Revert "docs: hvsupport: Add support for deprecating hypervisor
   implementations"

docs/hvsupport.pl           | 44 ++++++++++++-------------------------
docs/libvirt.css            | 10 ---------
include/libvirt/virterror.h |  1 -
src/qemu/qemu_driver.c      | 31 --------------------------
src/util/virerror.c         |  4 ----
5 files changed, 14 insertions(+), 76 deletions(-)


Missing a revert of:
commit 3026f6d9d986ad63c4b4a1c57589e6d05b71bd70
   news: Mention VIR_ERR_DEPRECATED in improvements

I wish it would have been the first news revert in this release cycle.

Jano

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux