Re: [PATCH 1/4] tests: Normalize quotes for *-graphics

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 14, 2019 at 10:04:36AM +0200, Andrea Bolognani wrote:
Right now *-headless and *-graphics tests are using different
quoting styles, which results in the diff between them being
basically useless, whereas we would like it to be possible to
compare these files directly and easily spot the differences.

Convert all *-graphics tests to single quotes, which is the
overwhelmingly more popular style

Irrelevant.

and also the one libvirt
itself uses when formatting XML,

This is the argument worth mentioning.

which is a fact that will
come in handy later.

Signed-off-by: Andrea Bolognani <abologna@xxxxxxxxxx>
---
.../aarch64-virt-graphics.xml                 | 50 ++++++++---------
.../ppc64-pseries-graphics.xml                | 48 ++++++++--------
tests/qemuxml2argvdata/s390x-ccw-graphics.xml | 46 +++++++--------
tests/qemuxml2argvdata/x86_64-pc-graphics.xml | 56 +++++++++----------
.../qemuxml2argvdata/x86_64-q35-graphics.xml  | 56 +++++++++----------
5 files changed, 128 insertions(+), 128 deletions(-)


Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx>

Jano

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux