Re: [PATCH 2/3] tests: qemustatusxml2xml: Add a seclabel for a disk with privateData

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 25, 2019 at 10:46:28 +0200, Ján Tomko wrote:
> On Mon, Jun 24, 2019 at 06:27:12PM +0200, Peter Krempa wrote:
> > Adding a seclabel breaks the output by improperly handling the XPath
> > context and thus not being able to parse the <privateData>.
> > 
> 
> However nice it is to see the effects of the fix during review, I think
> we should not be adding broken test data and this should be squashed
> with the next commit.

In that case it's pretty pointless to have the first commit as well.

I could also argue that the input data is valid in this case, so it's
not broken test data. Only the output is broken here.

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux