Re: [PATCH v3 1/2] docs: Use our own implementation for fetching the RSS data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 20, 2019 at 03:24:10PM +0200, Andrea Bolognani wrote:
On Thu, 2019-06-20 at 15:00 +0200, Martin Kletzander wrote:
[...]
     <script type="text/javascript">
       <!--
-      jQuery(function($) {
-        $("#planet").rss("http://planet.virt-tools.org/atom.xml";, {
-          ssl: true,
-          layoutTemplate: '<dl>{entries}</dl>',
-          entryTemplate: '<dt><a href="{url}">{title}</a></dt><dd>by {author} on {date}</li>',
-          dateFormat: 'DD MMM YYYY'
-        })
-      })
-      // -->
+      window.addEventListener("load", function() { fetchRSS() });
+  // -->

Still not aligned properly...

[...]
+        if (this.status != 200) {
+            console.error(this.statusText)

Missing semicolon.


I could not test this locally, obviously, and I'm not sure how you
could have either?


I have set up a local server which supplies the correct headers and then changed
"planet.virt-tools.org" to "localhost:8080".  Before posting I reverted the url
change back.  I also set up libvirt.org to point to localhost, but I still could
not test that because I would have to set up certificates for the httpd on
localhost.  And I already spend too much time on this.

Assuming you have made sure it works correctly before posting,

 Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>

--
Andrea Bolognani / Red Hat / Virtualization

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux