On Thu, Apr 25, 2019 at 10:19:49AM +0200, Michal Privoznik wrote: > The way that virSecurityDACRecallLabel is currently written is > that if XATTRs are not supported for given path to the caller > this is not different than if the path is still in use. The value > of 1 is returned which makes secdrivers skip label restore. > This is clearly a bug as we are not restoring labels on say NFS > even though previously we were. > > Strictly speaking, changes to virSecurityDACRememberLabel are not > needed, but they are done anyway so that getter and setter behave > in the same fashion. > > Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> > Reviewed-by: Cole Robinson <crobinso@xxxxxxxxxx> > --- > src/security/security_dac.c | 18 ++++++++++++------ > src/security/security_selinux.c | 21 +++++++++++++++------ > src/security/security_util.c | 6 ++++-- > 3 files changed, 31 insertions(+), 14 deletions(-) Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
