Re: [PATCH v4 07/25] qemusecuritytest: Fix capabilities loading

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 25, 2019 at 10:19:43AM +0200, Michal Privoznik wrote:
> Having to enumerate all capabilities that we want domain to have
> is too verbose and prevents us from adding more tests. Have the
> domain always have the latest x86_64 capabilities. This means
> that we have to drop two arm tests, but on the other hand, I'm
> introducing 50 new cases. I've listed 50 biggest .args files and
> added those:
> 
>   libvirt.git $ ls -Sr $(find tests/qemuxml2argvdata/ \
>   -type f -iname "*.x86_64-latest.args") | tail -n 50
> 
> Except for two:
> 1) disk-backing-chains-noindex - this XML has some disks with
> backing chain. And since set is done on the whole backing chain
> and restore only on the top layer this would lead to instant test
> failure. Don't worry, secdrivers will be fixed shortly too and
> the test case will be added.
> 
> 2) hostdev-mdev-display-spice-egl-headless - for this XML
> secdriver tries to find IOMMU group that mdev lives in. Since we
> are not mocking sysfs access this test case would fail.
> 
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
>  tests/qemusecuritytest.c | 69 ++++++++++++++++++++++++++++++----------
>  1 file changed, 53 insertions(+), 16 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux