Re: [PATCH v4 02/25] qemusecuritymock: Fix bit arithmetic

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 25, 2019 at 10:19:38AM +0200, Michal Privoznik wrote:
> One of the functions of this mock is that it spoofs chown() and
> stat() calls. But it is doing so in a clever way: it stores the
> new owner on chown() and reports it on subsequent stat(). This is
> done by using a 32bit unsigned integer where one half is used to
> store uid the other is for gid. Later, when stat() is called the
> integer is fetched and split into halves again. Well, my bit
> operation skills are poor and the code I've written does not do
> that properly.
> 
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
>  tests/qemusecuritymock.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux