On Mon, Jun 17, 2019 at 10:46:33AM +0200, Michal Privoznik wrote:
On 6/17/19 9:15 AM, Andrea Bolognani wrote:On Mon, 2019-06-17 at 01:19 +0200, Ján Tomko wrote:On Sat, Jun 15, 2019 at 03:17:22PM +0200, Michal Privoznik wrote:Since its introduction in v0.8.0~314 we allowed for cppi to be not present for 'syntax-check' because the package did exist in Fedora Core 12. Well, we don't care anymore ¯\_(ツ)_/¯ All recent distros have it. Moreover, it's fairly easy to miss 'cppi not installed' message in sea of syntax-check output (esp. for newbies who probably benefit from it the most). Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> --- cfg.mk | 32 ++++++++++++-------------------- 1 file changed, 12 insertions(+), 20 deletions(-)Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx>According to [1], only Fedora and FreeBSD have cppi packaged, so merging this patch will make 'make syntax-check' suddenly fail on all other target platforms. I agree that the current situation is suboptimal, though. How about we keep cppi optional, but print a more visible message about it not being available after going through all syntax-check rules? That way it'd be definitely more difficult to miss. [1] https://libvirt.org/git/?p=libvirt-jenkins-ci.git;a=blob;f=guests/vars/mappings.yml;h=98c0cc90c086d4b6d20c757062d679614e692ba4;hb=HEAD#l117Oh, you're right. I did not realize that cppi is not on CentOS and some other funky distros. So I guess our only option is to make the error message more visible, e.g. some banner? ********************** * cppi not installed * **********************
Yeah, you can also add it to BuildRequires and check for it during configure as warning there would be more visible, I guess. You can also require it only where you know it is available, but it might be too harsh. Just my $.02
Michal -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
