On Fri, Jun 14, 2019 at 15:51:31 +0200, Ján Tomko wrote:
> On Fri, Jun 14, 2019 at 03:30:25PM +0200, Peter Krempa wrote:
> > This code is really neglected and does not at all work reliably. It
> > can't even be used for converting our own commandline back.
> >
> > Since this was mostly useful for aiding migration from manually run qemu
> > to libvirt and will not work for this puspose in many cases it's not
>
> s/puspose/purpose/
>
> > worth having in my opinion.
> >
> > Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
> > ---
> > src/qemu/qemu_driver.c | 38 ++++++--------------------------------
> > 1 file changed, 6 insertions(+), 32 deletions(-)
> >
> > diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> > index bb6ba97c7a..7279b20d2e 100644
> > --- a/src/qemu/qemu_driver.c
> > +++ b/src/qemu/qemu_driver.c
> > @@ -7319,44 +7319,18 @@ static char
> >
> >
> > static char *qemuConnectDomainXMLFromNative(virConnectPtr conn,
> > - const char *format,
> > - const char *config,
> > + const char *format ATTRIBUTE_UNUSED,
> > + const char *config ATTRIBUTE_UNUSED,
> > unsigned int flags)
> > {
> > - virQEMUDriverPtr driver = conn->privateData;
> > - virDomainDefPtr def = NULL;
> > - char *xml = NULL;
> > - virCapsPtr caps = NULL;
> > -
> > virCheckFlags(0, NULL);
> >
> > if (virConnectDomainXMLFromNativeEnsureACL(conn) < 0)
> > - goto cleanup;
>
> I don't see a benefit in checking ACLs to report an error.
> Either way, it should be handled consistently - you removed the check
> from qemuDomainQemuAttach.
The ACL check is enforced by our syntax-check. In contrast to
virDomainQemuAttach which has "qemu" in the API name, in this case other
hypervisors driver might want to implement it and thus I don't think we
should add an exemption for this API.
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
