Re: [PATCH 04/12] tests: qemuMonitorTestProcessCommandDefaultValidate: simplify condition

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jun 15, 2019 at 13:54:02 +0200, Ján Tomko wrote:
> This function is skipped for non-JSON monitor (which never happens now)
> and for agent connections (which we currently do not test).
> 
> Only check for qapischema to simplify the condition.
> 
> Signed-off-by: Ján Tomko <jtomko@xxxxxxxxxx>
> ---
>  tests/qemumonitortestutils.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/qemumonitortestutils.c b/tests/qemumonitortestutils.c
> index bb30bed51e..cf4fec8873 100644
> --- a/tests/qemumonitortestutils.c
> +++ b/tests/qemumonitortestutils.c
> @@ -546,7 +546,7 @@ qemuMonitorTestProcessCommandDefaultValidate(qemuMonitorTestPtr test,
>      char *schemapath = NULL;
>      int ret = -1;
>  
> -    if (!test->qapischema || !test->json || test->agent)
> +    if (!test->qapischema)

The check for test->agent is necessary, since we don't know how to
validate the agent monitor schema.

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux