On Fri, 2019-06-14 at 08:07 +0200, Ján Tomko wrote: > On Thu, Jun 13, 2019 at 10:23:30AM -0500, Eric Blake wrote: > > On 6/13/19 10:06 AM, Ján Tomko wrote: > > > > > > Jonathon Jongsma (19): > > > > Use #pragma once in driver headers > > > > src/access: use #pragma once in headers > > > > src/admin: use #pragma once in headers > > > > src/bhyve: use #pragma once in headers > > > > conf: domain: use #pragma once in headers > > > > conf: network: use #pragma once in headers > > > > conf: nwfilter: use #pragma once in headers > > > > conf: node device: use #pragma once in headers > > > > conf: storage: use #pragma once in headers > > > > conf: misc: use #pragma once in headers > > > > src/cpu: use #pragma once in headers > > > > src/datatypes.h: use #pragma once > > > > src/esx: use #pragma once in headers > > > > src/hyperv: use #pragma once in headers > > > > src/interface: use #pragma once in headers > > > > src/internal.h: use #pragma once > > > > src/libvirt_internal.h: use #pragma once > > > > src/libxl: use #pragma once in headers > > > > src/logging: use #pragma once in headers > > > > > > > > Does this series add a syntax-check rule to prevent reversion back > > to > > older styles when new files are introduced? For example, I now > > have to > > rebase my pending incremental backup work on top of this, which > > adds new > > files, but without a syntax-check rule addition, I can't quickly > > identify which files I plan to add that need a tweak. > > > > Note that we do have syntax-check for this, it had to be loosened in: > commit ac41ffb8fa1235c226377397842c6c240a677d87 > Author: Cole Robinson <crobinso@xxxxxxxxxx> > AuthorDate: 2019-04-03 17:45:02 -0400 > Commit: Cole Robinson <crobinso@xxxxxxxxxx> > CommitDate: 2019-04-04 18:42:09 -0400 > > build-aux: header-ifdef: Handle #pragma once > > If we see it, skip all remaining header guard checks > > Acked-by: Eric Blake <eblake@xxxxxxxxxx> > Signed-off-by: Cole Robinson <crobinso@xxxxxxxxxx> > > But currently it accepts both variants. > > Jano Out of curiosity, do we want to use #pragma once in the public headers as well, or only the internal ones? Jonathon -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
