On Mon, Jun 10, 2019 at 11:04:57AM +0200, Ilias Stamatis wrote: > Changed in v2: > > * in testDomainSaveImageDefineXML check first that a saved image already > exists before parsing the new file > * reordered the arguments of testDomainSaveImageWrite in order for its > signature to be consistent with testDomainSaveImageOpen > > While implementing virDomainSaveImageGetXMLDesc and > virDomainSaveImageDefineXML for the test driver, I realized that there > exists already code for saving and loading test images which can be > reused. However, it needed to be extracted from testDomainSaveFlags and > testDomainRestoreFlags into separate functions. The new functions are > inspired by the corresponding QEMU driver code where e.g. > qemuDomainSaveImageOpen serves as a helper used by other functions. > > This series of patches initially extracts the code mentioned above into > separate functions and then provides the test driver with > implementations for virDomainSaveImageGetXMLDesc and > virDomainSaveImageDefineXML which make use of the newly introduced > functions. > > Ilias Stamatis (4): > test_driver: extract image saving code into a separate function > test_driver: extract image loading code into a separate function > test_driver: implement virDomainSaveImageDefineXML > test_driver: implement virDomainSaveImageGetXMLDesc > > src/test/test_driver.c | 293 ++++++++++++++++++++++++++++------------- > 1 file changed, 205 insertions(+), 88 deletions(-) Reviewed-by: Erik Skultety <eskultet@xxxxxxxxxx> -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
