On Wed, Jun 05, 2019 at 22:01:10 -0500, Eric Blake wrote: > The upcoming virDomainBackup() API needs to take advantage of the > ability to expose a bitmap as part of nbd-server-add for a pull-mode > backup (this is the recently-added QEMU_CAPS_NBD_BITMAP capability). > > Signed-off-by: Eric Blake <eblake@xxxxxxxxxx> > --- > src/qemu/qemu_monitor.h | 4 +++- > src/qemu/qemu_monitor_json.h | 4 +++- > src/qemu/qemu_migration.c | 2 +- > src/qemu/qemu_monitor.c | 10 +++++++--- > src/qemu/qemu_monitor_json.c | 7 ++++++- > tests/qemumonitorjsontest.c | 2 +- > 6 files changed, 21 insertions(+), 8 deletions(-) [...] > diff --git a/tests/qemumonitorjsontest.c b/tests/qemumonitorjsontest.c > index 9d707fcc7c..2a9e6cc75f 100644 > --- a/tests/qemumonitorjsontest.c > +++ b/tests/qemumonitorjsontest.c > @@ -1348,7 +1348,7 @@ GEN_TEST_FUNC(qemuMonitorJSONBlockCommit, "vdb", "/foo/bar1", "/foo/bar2", "back > GEN_TEST_FUNC(qemuMonitorJSONDrivePivot, "vdb") > GEN_TEST_FUNC(qemuMonitorJSONScreendump, "devicename", 1, "/foo/bar") > GEN_TEST_FUNC(qemuMonitorJSONOpenGraphics, "spice", "spicefd", false) > -GEN_TEST_FUNC(qemuMonitorJSONNBDServerAdd, "vda", true) > +GEN_TEST_FUNC(qemuMonitorJSONNBDServerAdd, "vda", NULL, true, NULL) Please use non-NULL attributes here to ensure schema checking. > GEN_TEST_FUNC(qemuMonitorJSONDetachCharDev, "serial1") > GEN_TEST_FUNC(qemuMonitorJSONBlockdevTrayOpen, "foodev", true) > GEN_TEST_FUNC(qemuMonitorJSONBlockdevTrayClose, "foodev") ACK with the non-null test added and make check re-run.
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
