On Fri, May 31, 2019 at 02:00:10PM +0200, Jiri Denemark wrote:
When the host CPU supports invariant TSC the host CPU definition created by virCPUx86GetHost will contain (unless probing fails for some reason) addition TSC related data. Signed-off-by: Jiri Denemark <jdenemar@xxxxxxxxxx> --- src/cpu/cpu_x86.c | 9 +++++++++ 1 file changed, 9 insertions(+)
This breaks the tests for me: 1) QEMU ARGV-2-XML machine-core-on ... Got unexpected warning from qemuParseCommandLineString: 2019-06-03 07:19:24.832+0000: 15141: info : libvirt version: 5.4.0 2019-06-03 07:19:24.832+0000: 15141: info : hostname: icr 2019-06-03 07:19:24.832+0000: 15141: error : virHostCPUGetTscInfo:1349 : Unable to open /dev/kvm: Permission denied FAILED Jano
diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c
index cb03123787..689b6cdaf5 100644
--- a/src/cpu/cpu_x86.c
+++ b/src/cpu/cpu_x86.c
@@ -2762,6 +2762,15 @@ virCPUx86GetHost(virCPUDefPtr cpu,
ret = x86DecodeCPUData(cpu, cpuData, models);
cpu->microcodeVersion = virHostCPUGetMicrocodeVersion();
+ /* Probing for TSC frequency makes sense only if the CPU supports
+ * invariant TSC (Linux calls this constant_tsc in /proc/cpuinfo). */
+ if (virCPUx86DataCheckFeature(cpuData, "invtsc") == 1) {
+ VIR_DEBUG("Checking invariant TSC frequency");
+ cpu->tsc = virHostCPUGetTscInfo();
+ } else {
+ VIR_DEBUG("Host CPU does not support invariant TSC");
+ }
+
cleanup:
virCPUx86DataFree(cpuData);
return ret;
--
2.21.0
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
