On Wed, 2019-05-22 at 16:12 +0200, Ján Tomko wrote: > On Wed, May 22, 2019 at 03:36:59PM +0200, Andrea Bolognani wrote: > > I don't much like the idea of adding a separate function that does > > almost the same thing but not quite, because that will ultimately > > result in the same situation we have now: someone will add a new > > callback and (reasonably) expect it to be called for all devices, > > but that won't happen because the original code uses the DeviceInfo > > variant instead of the Device one. That's unnecessary friction. > > So is having to argue about not putting if (!info) into every single > internal function that should not have been called with a NULL info in > the first place. Well, it's pretty clear at this point that we're not likely to ever reach an agreement. Let's just go with (some variation of) your version and then move on to something more productive. -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
