On Wed, 2019-05-22 at 13:45 +0200, Peter Krempa wrote: > On Wed, May 22, 2019 at 12:34:18 +0200, Ján Tomko wrote: > > On Wed, May 22, 2019 at 10:33:39AM +0200, Andrea Bolognani wrote: > > > Personally I like the idea of using the same input file for different > > > DO_TEST*() calls, highlighting how the environment is the only thing > > > causing differences in the output. That said, in the past I've been > > > told (I think by Peter?) doing so is not a good idea, so I've avoided > > > it since. > > > > For xml->argv test, the outputs are very different. But the xml->xml > > test only changes the machine type, which is IMO not worth including > > another input file. > > Note that the xml->argv code specifically deletes the default machine > type alias in the 'latest' tests capability data so that the > substitution is skipped. This is to avoid having change the files every > time we bump the latest caps file. > > For specific version tests we do want to do this so that we can also > excercise the default machine type code. This means also we should do > the same in the XML2XML tests. > > If the files differ only in the machine type default I don't think it's > worth having (except the case when we are specifically testing machine > type substitution). It looks like I was misremembering then. I've squashed in the diff Jano suggested, and pushed the first three patches of the series. Thanks for looking at it :) -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
