A double free may occur in testCompareXMLToArgvFiles() when @def is freed right after virStoragePoolObjNew() failed and the second time at cleanup label. Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> --- tests/storagepoolxml2argvtest.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/storagepoolxml2argvtest.c b/tests/storagepoolxml2argvtest.c index b7e32064af..0c01931946 100644 --- a/tests/storagepoolxml2argvtest.c +++ b/tests/storagepoolxml2argvtest.c @@ -39,7 +39,6 @@ testCompareXMLToArgvFiles(bool shouldFail, case VIR_STORAGE_POOL_NETFS: if (!(pool = virStoragePoolObjNew())) { VIR_TEST_DEBUG("pool type '%s' alloc pool obj fails\n", defTypeStr); - virStoragePoolDefFree(def); goto cleanup; } virStoragePoolObjSetDef(pool, def); -- 2.21.0 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list