On Fri, 2019-05-03 at 19:02 +0100, Daniel P. Berrangé wrote: > Support gtk-vnc and make virt-viewer depend on it Something that I forgot to mention yesterday, is that even after you install all required packages the build still fails on FreeBSD: $ mkdir build && cd build && ../autogen.sh ... checking sasl/sasl.h usability... no checking sasl/sasl.h presence... no checking for sasl/sasl.h... no configure: error: You must install the Cyrus SASL development package in order to compile GTK-VNC $ Interestingly, the FreeBSD port itself https://github.com/freebsd/freebsd-ports/blob/master/net/gtk-vnc/Makefile doesn't seem to play any tricks that would help configure locate the library - that is, of course, unless that 'bsd.port.mk' that gets included at the end does something crazy like adjust include and library paths so that /usr/local is searched as well. I haven't spent time digging. I see GTK-VNC is using old-school library detection and also seems to support both SASL and SASL2. In libvirt we only support SASL2 and use pkg-config for detection, and that works quite well on all platforms we target... I wonder if they'd consider doing the same? Either way, we have to address this before merging somehow if we want virt-viewer builds to keep succeeding on CentOS CI. -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
