Re: [PATCH 1/4] snapshot: s/parent/parent_name/ as prep for virObject

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 08, 2019 at 17:24:09 -0500, Eric Blake wrote:
> VIR_CLASS_NEW insists that descendents of virObject have 'parent' as
> the name of their inherited member at offset 0. While it would be
> possible to write a new class-creation macro that takes the actual
> field name, and rewrite VIR_CLASS_NEW to call the new macro with the
> hard-coded name 'parent', so that we could make virDomainMomentDef use
> a custom name for its base class, it seems less confusing if all
> object code uses similar naming. Thus, this is a mechanical rename in
> preparation of making virDomainSnapshotDef a descendent of virObject,
> when we can no longer use 'parent' for a different purpose than the
> base class.
> 
> Signed-off-by: Eric Blake <eblake@xxxxxxxxxx>
> ---
>  src/conf/moment_conf.h            |  2 +-
>  src/conf/moment_conf.c            |  2 +-
>  src/conf/snapshot_conf.c          | 22 ++++++++++++----------
>  src/conf/virdomainmomentobjlist.c |  4 ++--
>  src/esx/esx_driver.c              |  2 +-
>  src/qemu/qemu_domain.c            |  8 ++++----
>  src/qemu/qemu_driver.c            | 12 ++++++------
>  src/test/test_driver.c            | 18 +++++++++---------
>  src/vbox/vbox_common.c            | 14 +++++++-------
>  src/vz/vz_sdk.c                   |  2 +-
>  10 files changed, 44 insertions(+), 42 deletions(-)

ACK

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux