On Thu, May 09, 2019 at 10:30:25AM +0200, Andrea Bolognani wrote: > On Wed, 2019-05-08 at 17:29 +0100, Daniel P. Berrangé wrote: > > On Wed, May 08, 2019 at 06:21:21PM +0200, Olaf Hering wrote: > > > On Wed, Apr 03, Ján Tomko wrote: > > > > > > > Since all our supported platforms include at least yajl 2.0.4, > > > > use pkg-config to detect the library and set the minimum to 2.0.3. > > > > > > In case SLE_12 is on the list of supported platforms, this kicked it > > > off of the list. SLE_12 (and Leap 42.3) comes with version 2.0.1. > > > SLE_15 has version 2.1.0. > > > > Yes, this is a mistake. > > > > https://libvirt.org/platforms.html > > > > "For distributions with long-lifetime releases, the project will aim > > to support the most recent major version at all times. Support for > > the previous major version will be dropped 2 years after the new > > major version is released. For the purposes of identifying supported > > software versions, the project will look at RHEL, Debian, Ubuntu LTS, > > and SLES distros. " > > > > SLE 15 was released July 2018, so we should be continuing to support > > SLE 12 until July 2020. > > > > So we need to fix this to allow fallback to the non-pkg-config detection > > for yajl. > > Well that's a bummer, but at least we don't have to re-introduce > support for YAJL 1 - just fix YAJL 2 detection. > > We should really add support for SLES, or whatever its CentOS > equivalent is, to libvirt-jenkins-ci, though. Yeah, openSUSE Leap is the one we'd want to add support for. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
