On Tue, May 07, 2019 at 12:15:54 +0100, Daniel Berrange wrote: > On Tue, May 07, 2019 at 12:49:18PM +0200, Michal Privoznik wrote: > > On 5/7/19 11:13 AM, Daniel P. Berrangé wrote: > > > On Mon, May 06, 2019 at 10:01:37AM +0200, Michal Privoznik wrote: > > > > There are some scripts/binaries that are not tests themselves but > > > > rather fulfill support purpose. Separate them from the rest of > > > > the tests. > > > > > > > > Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> > > > > --- [...] > > Personally, I find having code along side with the tests even more > > disaranged than what we have now. For some unit tests we can have strict > > naming scheme: virhash.c -> virhashtest.c; but for some more advanced tests > > qemuxml2*test this won't work. > > We don't need to rename everything - that could be src/qemu/qemuxml2argvtest.c > easily enough Ewwww that is super gross. I strongly prefer to keep the tests stashed into a directory (thus qemu/tests/qemuxml2argvtest.c) to avoid having a gazillion files in the main directory for the driver.
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
