On Tue, 2019-04-16 at 11:19 +0100, Daniel P. Berrangé wrote: > +.job_template: &job_definition > + script: > + - mkdir vpath > + - cd vpath We use build/ for CentOS CI and Travis CI builds, so let's stick with that here as well. > + - ../autogen.sh $CONFIGURE_OPTS We have some code to show the contents of config.log when this steps fails in other CI environments, would it be a good idea to have it here as well? Everything else looks reasonable, at least based on my extremely shallow knowledge of GitLab CI, so as far as I'm concerned we can just merge this and fix whatever issue might pop up later. Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx> -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
