On Mon, May 06, 2019 at 08:56:55PM +0000, Carvalho, Larkins L wrote: > Hello Peter, > > Thank you for the feedback. > I'll submit another patch series. > > I have a question regarding the test cap replies file. > We are querying Qemu to get the capability information. > The Qemu patch is not yet upstream, hence, we are not able to create > the replies file for the same. Either leave out the replies file, or just apply your MKTME patches to upstream QEMU in your local checkout & generate replies file from that. Then you can update the patch with new replies file once the QEMU pieces finally merge. > Is it ok to submit the patch for the feedback without the replies file? > Since the Qemu support for MKTME is not yet upstream and without Qemu > support we cannot merge this changes to Libvirt. Libvirt won't merge the patches until the corresponding QEMU piece is merged, but we have happy to review patches at any time. Indeed it is *good* to have libvirt patches reviewed before QEMU stuff is merged, as that makes it easier if we spot things that can be improved in QEMU for help libvirt. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
