Re: [PATCH 3/4] qemu: On attach to live XML check for user alias collision only live XML

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Apr 26, 2019 at 15:52:22 +0200, Michal Privoznik wrote:
> When attaching a device to live XML we don't care (well,
> shouldn't care) that there's already a device in inactive XML
> that has the same user alias.
> 
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
>  src/qemu/qemu_driver.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index 2b2d531441..40fd8b9d2d 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -8663,7 +8663,8 @@ qemuDomainAttachDeviceLiveAndConfig(virDomainObjPtr vm,
>                                                  driver->xmlopt, parse_flags)))
>              goto cleanup;
>  
> -        if (virDomainDeviceValidateAliasForHotplug(vm, devLive, flags) < 0)
> +        if (virDomainDeviceValidateAliasForHotplug(vm, devLive,
> +                                                   VIR_DOMAIN_AFFECT_LIVE) < 0)
>              goto cleanup;

ACK

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux