On Fri, Apr 26, 2019 at 15:52:21 +0200, Michal Privoznik wrote: > If we're attaching a device to both inactive and live XML then > @ret is overwritten which may result in incorrect return value. > For instance, if attaching to inactive XML succeeds, @ret is > assigned value of zero and control proceeds to attaching the > device to live XML. Here, if say > virDomainDeviceValidateAliasForHotplug() fails the control jumps > over to 'cleanup' label and zero is returned indicating success. > > Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> > --- > src/qemu/qemu_driver.c | 23 +++++++++++------------ > 1 file changed, 11 insertions(+), 12 deletions(-) ACK
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
