Each attribute is on its own line. We forgot to add new line character for <alias/> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> --- Pushed under trivial rule. tools/virsh-domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index da57d96d1a..82140feb57 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -683,7 +683,7 @@ cmdAttachDisk(vshControl *ctl, const vshCmd *cmd) virBufferAsprintf(&buf, "<serial>%s</serial>\n", serial); if (alias) - virBufferAsprintf(&buf, "<alias name='%s'/>", alias); + virBufferAsprintf(&buf, "<alias name='%s'/>\n", alias); if (wwn) virBufferAsprintf(&buf, "<wwn>%s</wwn>\n", wwn); -- 2.21.0 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list