Re: [PATCH v8 10/21] conf: Add parameter to virDomainDiskSourceFormat

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 17, 2019 at 09:09:10 -0500, Eric Blake wrote:
> Commits 4bc42986 and 218c81ea removed virDomainStorageSourceFormat on
> the grounds that there were no external callers; however, the upcoming
> backup code wants to output a <target> (push mode) or <scratch> (pull
> mode) element that is in all other respects identical to a domain's
> <source> element, where the previous virDomainStorageSourceFormat fit
> the bill nicely. But rather than reverting the commits, it's easier to
> just add an additional parameter for the element name to use, and
> update all callers.
> 
> Signed-off-by: Eric Blake <eblake@xxxxxxxxxx>
> ---
>  src/conf/domain_conf.h   |  1 +
>  src/conf/domain_conf.c   | 14 +++++++++-----
>  src/conf/snapshot_conf.c |  3 ++-
>  src/qemu/qemu_domain.c   |  2 +-
>  tests/qemublocktest.c    |  3 ++-
>  tests/virstoragetest.c   |  2 +-
>  6 files changed, 16 insertions(+), 9 deletions(-)

ACK

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux