Re: [PATCH v4 0/3] Don't pm suspend guest if it's unable to wake up

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/24/19 11:16 PM, Daniel Henrique Barboza wrote:
changes from v3:

- patch 3 removed. We no longer consider PM_WAKEUP_SUPPORT a
cap. It is confusing to have a 'runtime cap' that can't be resolved
inside qemu_capabilities.c. The suspend operation isn't time
critical per se, and a call to QMP each time 'virsh dompmsuspend'
is executed is not dreadful to the user experience. More information
and discussion can be found at [1].

- due to the change above, patch 4 now executes the
query-current-machine QMP call (if the running QEMU instance supports
it) during qemuDomainPMSuspendForDuration to check if the guest
has wakeup support.

- previous patch link:

[1] https://www.redhat.com/archives/libvir-list/2019-April/msg00767.html


Daniel Henrique Barboza (2):
   qemu_capabilities: Add QEMU_CAPS_QUERY_CURRENT_MACHINE
   qemuDomainPMSuspendForDuration: check for wake-up support

Michal Prívozník (1):
   qemu_monitor: Introduce handler for 'query-current-machine' command

  src/qemu/qemu_capabilities.c                  |  2 +
  src/qemu/qemu_capabilities.h                  |  1 +
  src/qemu/qemu_driver.c                        | 54 +++++++++++++++++++
  src/qemu/qemu_monitor.c                       | 10 ++++
  src/qemu/qemu_monitor.h                       |  9 ++++
  src/qemu/qemu_monitor_json.c                  | 50 +++++++++++++++++
  src/qemu/qemu_monitor_json.h                  |  5 ++
  .../caps_4.0.0.riscv32.xml                    |  1 +
  .../caps_4.0.0.riscv64.xml                    |  1 +
  .../caps_4.0.0.x86_64.xml                     |  1 +
  10 files changed, 134 insertions(+)



Fixed, ACKed and pushed.

Michal

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux