On 4/12/19 7:25 PM, Jim Fehlig wrote:
On 4/11/19 8:34 AM, Michal Privoznik wrote:
This is an alternative approach to:
https://www.redhat.com/archives/libvir-list/2019-March/msg01111.html
which caused regression to which a proposed fix is here:
https://www.redhat.com/archives/libvir-list/2019-April/msg00756.html
One of the selling points was that having this check in
virDomainDefCompatibleDevice() will fix the problem across all drivers.
Well, turns out, some drivers don't care (e.g. lxc) and some have a
different workflow and thus don't need that check.
Michal Prívozník (4):
conf: Expose virDomainSCSIDriveAddressIsUsed
qemuhotplugtest: Don't plug a SCSI disk at unit 7
qemu_hotplug: Check for duplicate drive addresses
Revert "domain_conf: check device address before attach"
src/conf/domain_conf.c | 11 +----------
src/conf/domain_conf.h | 4 ++++
src/libvirt_private.syms | 1 +
src/qemu/qemu_hotplug.c | 6 ++++++
tests/qemuhotplugtest.c | 2 +-
.../qemuhotplug-disk-scsi-2.xml | 2 +-
...-base-without-scsi-controller-live+disk-scsi-2.xml | 4 ++--
7 files changed, 16 insertions(+), 14 deletions(-)
Thanks. I reviewed and tested the series.
Reviewed-by: Jim Fehlig <jfehlig@xxxxxxxx>
Oh forgot to push those. Sorry. Now pushed.
Thank you both.
Michal
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list
